Manage the Nextcloud trash #4432
Conversation
The path for files/directories inside the NextCloud trashbin are NOT their parent path + their name, but also contains a suffix. So, we need to add the path to the response to allow the clients to make operations on them.
| "attributes": { | ||
| "type": "directory", | ||
| "name": "Old", | ||
| "path": "/trash/Old.d93571568", |
There was a problem hiding this comment.
@cballevre be careful, the path for things inside the trash is a bit weird and cannot be computed with just the parent and the name, so it was added to the response
There was a problem hiding this comment.
Interesting clarification. I saw that you added the path everywhere. In cozy-client, I add a second attribute named parentPath. It corresponds to the folder path. This is to make it easier to replay requests with sift.js (commit with some explanation). Wouldn't it make sense to add it to the back as well, so we wouldn't have to calculate anything on the front?
| } | ||
|
|
||
| func (nc *NextCloud) Upload(path, mime string, contentLength int64, body io.Reader) error { | ||
| headers := map[string]string{ | ||
| echo.HeaderContentType: mime, | ||
| } | ||
| path = "/files/" + nc.userID + "/" + path |
There was a problem hiding this comment.
Looks like it could be the right time to add a filePath(path string) and a trashedPath(path string) methods?!
There was a problem hiding this comment.
For filePath, I'm not convinced, but why not. For trashedPath, it doesn't work, we have subtle differences from one line to another.
| @@ -167,7 +174,36 @@ func (nc *NextCloud) ListFiles(path string) ([]jsonapi.Object, error) { | |||
| return files, nil | |||
| } | |||
|
|
|||
| func (nc *NextCloud) ListTrash(path string) ([]jsonapi.Object, error) { | |||
There was a problem hiding this comment.
Since we're not listing the content of the Trash but the content of a trashed item, I would suggest going for ListTrashed instead.
The same goes for buildTrashedUrl and TrashedName.
No description provided.