Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VFS] Add a vfs package #43

Merged
merged 7 commits into from
Oct 12, 2016
Merged

[VFS] Add a vfs package #43

merged 7 commits into from
Oct 12, 2016

Conversation

jinroh
Copy link
Contributor

@jinroh jinroh commented Oct 12, 2016

This PR is only refactorization. The main idea is to export the vfs parts in its own package to give us some space for what is coming next.

The diff may be hard to read so here exact list of what it does:

  • create a package vfs with all the code specific to vfs, file and directory handling (no gin)
  • add error handling in vfs/errors
  • renamed vfs.DocMetadata struct into vfs.DocAttributes and make its fields private
  • add mime, class and size fields to vfs.DocAttributes to be more consistent
  • use web/errors in web/files to be consistent with web/data

Copy link
Contributor

@aenario aenario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, in the future we can imagine having some of the parsing (MD5 & content-length) moved to middlewares.

@nono nono merged commit 067be54 into cozy:master Oct 12, 2016
@jinroh jinroh deleted the vfs-package branch October 12, 2016 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants