Fix a source of VFS inconsistency #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new file is uploaded, and the stack tries to save the io.cozy.files in CouchDB, it may happen that an error occurs and the stack doesn't know if the document has been saved or not in CouchDB (timeout, network issue, CouchDB unavailable). In that case, it is safer to try to delete the document in CouchDB. It is not perfect. For example, if CouchDB has accepted the document just before becoming unavailable, the deletion will fail (CouchDB unavailable), and it will still have an inconsistency. But, at least, it should reduce the number of cases.
taratatach
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new file is uploaded, and the stack tries to save the io.cozy.files in CouchDB, it may happen that an error occurs and the stack doesn't know if the document has been saved or not in CouchDB (timeout, network issue, CouchDB unavailable). In that case, it is safer to try to delete the document in CouchDB.
It is not perfect. For example, if CouchDB has accepted the document just before becoming unavailable, the deletion will fail (CouchDB unavailable), and it will still have an inconsistency. But, at least, it should reduce the number of cases.