Remove qid vs id, add _type field #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenario
force-pushed
the
replace-qid-types
branch
3 times, most recently
from
cbc676a
to
4b9cfa6
Compare
nono
reviewed
Oct 12, 2016
| @@ -21,7 +20,7 @@ type dirAttributes struct { | |||
| // interfaces. | |||
| type DirDoc struct { | |||
| // Qualified file identifier | |||
| QID string `json:"_id"` | |||
| QID string `json:"_id,omitempty"` | |||
There was a problem hiding this comment.
@aenario shouldn't QID be renamed in ID?
There was a problem hiding this comment.
it would conflict with the ID() method. but i agree we should find another name (or make it private..)
jinroh
reviewed
Oct 12, 2016
| return "" | ||
| } | ||
| return qid[0:strings.Index(qid, "/")] | ||
| return j.Type | ||
| } | ||
|
|
||
| // SetID is used to set the qualified identifier of the document |
There was a problem hiding this comment.
s/qualified indentifier/identifier/ (there may be other comments using this term)
aenario
force-pushed
the
replace-qid-types
branch
from
2613c03
to
9aca913
Compare
aenario
force-pushed
the
replace-qid-types
branch
from
56549ac
to
c10f98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.