Move all the redis init logic inside it's own package #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition stopping the stack in case of conflict between the `localOpt` variable and the `mainOpt` is setup since 2017. The systematic setup of `mainOpt` also date of 2017. This means that since 2017, a server with a `localOpt` can start. We can deduce that this is feature is long gone an can be removed safely in favor or a `Universal` client able to handle a single-node client or a cluster client as well.
nono
requested changes
Jun 20, 2023
| @@ -292,27 +292,8 @@ func NewRedisConfig(u string) (conf RedisConfig, err error) { | |||
|
|
|||
| // GetRedisConfig returns a | |||
| func GetRedisConfig(v *viper.Viper, mainOpt *redis.UniversalOptions, key, ptr string) (conf RedisConfig, err error) { | |||
| var localOpt *redis.Options | |||
|
|
|||
| localKey := fmt.Sprintf("%s.%s", key, ptr) | |||
There was a problem hiding this comment.
We must keep the localOpt. It is used for the flags, like in cozy-stack serve --lock-url=redis:https://localhost:6379/1.
|
The other commits look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.