Dont init the logger inside config

[Peltoche]

No description provided.

[nono]

There are some CLI commands like cozy-stack jobs run, for which we want to have initialized loggers, but the stack init is not called

[Peltoche]

There are some CLI commands like cozy-stack jobs run, for which we want to have initialized loggers, but the stack init is not called

Seems that we don't use the logger for that but directly fmt.Printf:

		if flagJobPrintLogs {
			o.Logs = make(chan *client.JobLog)
			go func() {
				for log := range o.Logs {
					fmt.Printf("[%s]", log.Level)
					if flagJobPrintLogsVerbose {
						fmt.Printf("[time:%s]", log.Time.Format(time.RFC3339))
						for k, v := range log.Data {
							fmt.Printf("[%s:%s]", k, v)
						}
					}
					fmt.Printf(" %s\n", log.Message)
				}
			}()
		}

I don't see any import to logrus or pkg/log* in /cmd

[nono]

OK, bad example. Let's take cozy-stack fix mime.

[nono]

Or the cozy-stack swift ...

[Peltoche]

Both seems to do only calls via the http client and use fmt.Print* for the outputs. This seems coherent, if this was not the case this would mean that we are running server code directly inside the client and we would have logrus outputs for the cli.

[nono]

if this was not the case this would mean that we are running server code directly inside the client

We do have server code running inside the client. I don't remember for which commands, it is a legacy things. When I have time, I try to rewrite them to move the code on the server, but I don't think we are done.

[Peltoche]

Ok, good to know.

And for those case the default logrus config is not enough? All we want we want is to print the logs on stdout and the logrus.StandardLogger does that by default. If we don't call logger.Init we will fallback on the default logrus logger config with a MemDebugger.

[nono]

All we want we want is to print the logs on stdout and the logrus.StandardLogger does that by default.

Nope, I would prefer to send the logs to syslog. What should be printed on stdout or stderr should use an explicit fmt.Printf (or equivalent).

[Peltoche]

Everyone seems to aggreed that if there is some remaining logs on cozy-stack we should send them on syslog and not stdout.

This review could be resolved when we will be sure that there is no more logs inside cozy-stack