Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status conversion in Couchdb Error #34

Closed
wants to merge 4 commits into from
Closed

Fix status conversion in Couchdb Error #34

wants to merge 4 commits into from

Conversation

tomsquest
Copy link
Contributor

  • Converting the status code from int to string was done using string() instead of strconv.ItoA().
  • Test case created.
  • Minor fixes/cleanup

@nono
Copy link
Member

nono commented Oct 7, 2016

Thanks for the PR. I was working on the same files, you should look at my PR: #33

@tomsquest
Copy link
Contributor Author

If there are conflicts between our two branches, could you cherry-pick/apply these/changes and closes this PR (I am not emotionally attached to it 😉 ).

@tomsquest
Copy link
Contributor Author

@nono Just thinking about it: the status field in ther Error json is a string. Shouldn'it it be kept as an int, or it could be renamed as statusCode (principle of least surprise). WDYT ?

@nono
Copy link
Member

nono commented Oct 7, 2016

@tomsquest we want to stay close to the couchdb API, and couchdb uses status with a string, so we will keep that

@jinroh
Copy link
Contributor

jinroh commented Oct 7, 2016

@tomsquest I've merged #33 and opened another PR #35 with your rebased changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants