Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve help message #32

Merged
merged 3 commits into from
Oct 7, 2016
Merged

Serve help message #32

merged 3 commits into from
Oct 7, 2016

Conversation

jinroh
Copy link
Contributor

@jinroh jinroh commented Oct 7, 2016

Little morning nitpicking PR on naming and help messages:

  • rephrased the outdated help serve message
  • renamed the Address config param to Host, which I think is more correct..
  • more consistent help messages for flags

@nono nono merged commit fbfe3f8 into cozy:master Oct 7, 2016
@jinroh jinroh deleted the serve-help-message branch October 7, 2016 07:48
url := &url.URL{
Scheme: "http",
Host: config.GetConfig().Host + ":" + strconv.Itoa(config.GetConfig().Port),
Path: "/status",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ can be removed as URL adds it automatically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomsquest
Copy link
Contributor

😄 I used host as my first version, then switched to address because gin uses it as the param name. But reading the code, host is far more understandable !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants