Add a status command #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenario
approved these changes
Sep 19, 2016
| Run: func(cmd *cobra.Command, args []string) { | ||
| port := os.Getenv("PORT") | ||
| if len(port) == 0 { | ||
| port = "8080" |
There was a problem hiding this comment.
We should let viper handle the whole config or ENV or default. Can be the object of a separate PR.
There was a problem hiding this comment.
Yes, it should be better. For the moment, it's just the default way of how gin works. But later, we should definetively move that in viper.
| resp, err := http.Get("http:https://localhost:" + port + "/status") | ||
| if err != nil { | ||
| fmt.Println("Error the HTTP server is not running:", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Should we have significant error code ? In which case we should use named constants.
There was a problem hiding this comment.
I think we should just have 0 for OK and something else for an error. Error messages are more convenient to know what has failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.