First shot at read api. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
reviewed
Oct 3, 2016
| return &CouchdbError{http.StatusServiceUnavailable, | ||
| []byte("{\"error\":\"No couch to seat on.\"}")} | ||
| } | ||
| body, err := ioutil.ReadAll(resp.Body) |
There was a problem hiding this comment.
I think you need to close the body:
defer resp.Body.Close()
|
I think you should merge master in this branch to resolve the conflict |
jinroh
reviewed
Oct 3, 2016
| url := DocURL(dbprefix, doctype, id) | ||
| fmt.Printf("[couchdb request] %v\n", url) | ||
| req, err := http.NewRequest("GET", url, nil) | ||
| req.Header.Add("Accept", "application/json") |
There was a problem hiding this comment.
this req.Header.Add should probably be after the if err != nil.
|
OK, I figured out what was wrong with my setup (wrong GOPATH in profile made the linters atom plugins fail silently). So now, gofmt get applied, gometalinter too and travis is happy, which makes me happy. Both your reviews comment have been fixed in f214b15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is the first shot at GetDoc API
It is based on 3 commits by @nono which introduce the instance concept.
Some design decisions :
gin.ErrorLoggerto output json errorsLeft TODO :
_$()+-/a-zA-Z0-9in host or doctype, or if the host doesnt start with aa-z.@nono, there is a merge conflict with master. I could fix-it by merging master into this branch, or rebasing this branch on master, but it gets messy with your commits included here.