Remove swift versionning from swift vfs impl v1 & v2 #1638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
requested changes
Dec 3, 2018
| // on the container and the old object should be restored. | ||
| // TODO(xxx): We previously used X-Versions-Location on the container and | ||
| // the old object should be restored so deleting the object was secure. | ||
| // This not the case anymore so maybe we should add some error handling here. |
There was a problem hiding this comment.
We really need to fix this (layout v1 and v2) before merging this PR, or we may lose files in production
|
I close this pull request. We still want to remove Swift versioning, but the way to do that is moving to a new Swift layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove swift versionning in swift VFS (implementation v1 and v2).
Swift versionning causes a lot of problems with zero gain:
Simply removing container versionning is the quickest way to fix this.