OAuth POST /auth/authorize #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 54.96% (diff: 89.53%)@@ master #147 diff @@
==========================================
Files 31 32 +1
Lines 2926 2978 +52
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1589 1637 +48
- Misses 1093 1096 +3
- Partials 244 245 +1
|
aenario
approved these changes
Dec 13, 2016
jinroh
reviewed
Dec 14, 2016
| CookieMaxAge: 3600, // 1 hour | ||
| CookieHTTPOnly: true, | ||
| CookieSecure: true, | ||
| }) |
There was a problem hiding this comment.
could it be interesting to store the CSRF in the session instead of using another cookie ?
There was a problem hiding this comment.
Well, I think another cookie is fine. I don't see a pro for using the session for CSRF, and there is a con: the echo middleware won't support that out of the box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.