CORS middleware #115
Merged
CORS middleware #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 50.19% (diff: 91.17%)@@ master #115 diff @@
==========================================
Files 28 29 +1
Lines 2544 2588 +44
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1268 1299 +31
- Misses 1058 1070 +12
- Partials 218 219 +1
|
nono
reviewed
Nov 25, 2016
| @@ -38,10 +43,64 @@ func SetupRoutes(router *gin.Engine) { | |||
| router.Use(middlewares.ParseHost()) | |||
| router.Use(middlewares.ServeApp(apps.Serve)) | |||
| router.Use(middlewares.ErrorHandler()) | |||
| router.Use(corsMiddleware("/apps", "/data", "/files")) | |||
There was a problem hiding this comment.
Why did you insert the middleware here, and not like middlewares.NeedInstance in each Group?
There was a problem hiding this comment.
This is what i wanted to do, but in the way gin works I would have to add an empty router.OPTIONS handler on each one of these routes to not get a 404 on the preflight request.. I opted for a "global" middleware of this reason...
There was a problem hiding this comment.
OK, you should note this in a comment. It could be helpful later to remember that
nono
reviewed
Nov 25, 2016
| origin := c.Request.Header.Get("Origin") | ||
| if origin == "" { | ||
| return | ||
| } |
There was a problem hiding this comment.
TODO for later: check that the Origin header matches a subdomain of the instance or a registered domain for an OAuth2 app/device.
nono
approved these changes
Nov 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple CORS middleware and fix the
Hostforwarding by the proxy.