fix: new properties are ignored with allOf when using $ref #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblanchette
pushed a commit
that referenced
this pull request
Aug 30, 2024
## [1.0.3](v1.0.2...v1.0.3) (2024-08-30) ### Bug Fixes * new properties are ignored whith allOf using $ref ([#249](#249)) ([7049af7](7049af7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, added properties are ignored when using a single
allOfwith a$ref, or when using$refdelegation (see above examples).With delegation (starting from Draft 2019-09)
{ "$ref": "#/schemas/myschema", "properties": { "newProperty": { "type": "string" } } }Using "allOf" (pre Draft 2019-09)
{ "allOf": [ { "$ref": "#/schemas/myschema" } ], "properties": { "newProperty": { "type": "string" } } }This PR fixes the issue by merging additional properties as they should (considering that the result of this
allOfshould be anded properties).Note that conflicts that could occur on wrong JSON schemas are ignored.
Fixes #192
Fixes #131