Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unstable enum description templating_utils.py #243

Merged
merged 1 commit into from
May 16, 2024

Conversation

esdete
Copy link
Contributor

@esdete esdete commented May 14, 2024

set is not ordered and may lead to not reproducible results between different python implementation. The root cause probably lays in different hash function implementation.

Windows Python 3.10.11:

>>> set((type(None),str)) 
{<class 'NoneType'>, <class 'str'>}

Ubuntu Python 3.10.11

>>> set((type(None), str))
{<class 'str'>, <class 'NoneType'>}

set is not ordered and may lead to not reproducible results between different python implementation. The root cause probably lays in different hash function implementation. 

Windows Python 3.10.11:
>>> set((type(None),str)) 
{<class 'NoneType'>, <class 'str'>}

Ubuntu Python 3.10.11
>>> set((type(None), str))
{<class 'str'>, <class 'NoneType'>}
@dblanchette dblanchette merged commit c304af8 into coveooss:main May 16, 2024
5 checks passed
dblanchette pushed a commit that referenced this pull request May 16, 2024
## [1.0.2](v1.0.1...v1.0.2) (2024-05-16)

### Bug Fixes

* Fix for unstable enum description templating_utils.py ([#243](#243)) ([c304af8](c304af8))
@dblanchette
Copy link
Collaborator

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants