Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastLitParser should parse number into float64 if int64 overflows #99

Closed
nelio2k opened this issue Apr 9, 2019 · 0 comments
Closed

fastLitParser should parse number into float64 if int64 overflows #99

nelio2k opened this issue Apr 9, 2019 · 0 comments
Assignees
@nelio2k
Labels
bug

Comments

@nelio2k
Copy link
Collaborator

nelio2k commented Apr 9, 2019

When an integer fastVal is used to compare against a float, and the float that is being compared to can overflow an int64, the comparison result is more than likely to be incorrect.
@nelio2k nelio2k added the bug label Apr 9, 2019
@nelio2k nelio2k self-assigned this Apr 9, 2019
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue Apr 9, 2019
@nelio2k
Fixes couchbaselabs#99 - int comparison to a large float that overflo…
15e8002 
…ws an int64 should use float comparison
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue Apr 9, 2019
@nelio2k
Fixes couchbaselabs#99 - int comparison to a large float that overflo…
bc5d823 
…ws an int64 should use float comparison
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue Apr 10, 2019
@nelio2k
Fixes couchbaselabs#99 - int comparison to a large float that overflo…
9ca8739 
…ws an int64 should use float comparison
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue Apr 11, 2019
@nelio2k
Fixes couchbaselabs#99 - int comparison to a large float that overflo…
afc8faf 
…ws an int64 should use float comparison
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue Apr 11, 2019
@nelio2k
Fixes couchbaselabs#99 - int comparison to a large float that overflo…
40ce351 
…ws an int64 should use float comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelio2k nelio2k

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelio2k