Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially seg fault when comparing invalid dates #107

Closed
nelio2k opened this issue May 29, 2019 · 0 comments
Closed

Potentially seg fault when comparing invalid dates #107

nelio2k opened this issue May 29, 2019 · 0 comments
Assignees
@nelio2k
Labels
bug

Comments

@nelio2k
Copy link
Collaborator

nelio2k commented May 29, 2019

https://issues.couchbase.com/browse/MB-34363 was discovered when running a date comparison on invalid formats.
@nelio2k nelio2k added the bug label May 29, 2019
@nelio2k nelio2k self-assigned this May 29, 2019
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue May 29, 2019
@nelio2k
Fixes couchbaselabs#107:
04a7d14 
  - Added a more generic couchbase sample bucket date format
  - Check before date comparisons to make sure to not execute on a nil fastval
  - Fixes parser to allow correct capturing of FEValue, and remove redundant checks
  - Added some basic date function syntax checks to prevent entering of invalid date formats,
    which may yield incorrect results since any invalid comparison returns a valid result of -1
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue May 29, 2019
@nelio2k
Fixes couchbaselabs#107:
58e1a80 
  - Added support for a more generic couchbase sample bucket date format
  - Check before date comparisons to make sure to not execute on a nil fastval
  - Fixes parser to allow correct capturing of FEValue, and remove redundant checks
  - Added some basic date function syntax checks to prevent entering of invalid date formats,
    which may yield incorrect results since any invalid comparison returns a valid result of -1
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue May 29, 2019
@nelio2k
Fixes couchbaselabs#107:
e38307f 
  - Added support for a more generic couchbase sample bucket date format
  - Check before date comparisons to make sure to not execute on a nil fastval
  - Fixes parser to allow correct capturing of FEValue, and remove redundant checks
  - Added some basic date function syntax checks to prevent entering of invalid date formats,
    which may yield incorrect results since any invalid comparison returns a valid result of -1
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue May 30, 2019
@nelio2k
Fixes couchbaselabs#107:
4a202a7 
  - Added support for a more generic couchbase sample bucket date format
  - Check before date comparisons to make sure to not execute on a nil fastval
  - Fixes parser to allow correct capturing of FEValue, and remove redundant checks
  - Enable comparison of nil time fastvals
nelio2k added a commit to nelio2k/gojsonsm that referenced this issue May 30, 2019
@nelio2k
Fixes couchbaselabs#107:
b377765 
  - Added support for a more generic couchbase sample bucket date format
  - Check before date comparisons to make sure to not execute on a nil fastval
  - Fixes parser to allow correct capturing of FEValue, and remove redundant checks
  - Enable comparison of nil time fastvals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelio2k nelio2k

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelio2k