Allow ip command #376
Open
Allow ip command #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a81ed02
to
2b7ab17
Compare
chvck
reviewed
Aug 7, 2024
src/cli/allow_ip.rs
Outdated
| } | ||
|
|
||
| fn usage(&self) -> &str { | ||
| "Whitelists an IP address on a Capella cluster" |
There was a problem hiding this comment.
"Adds an IP address to the allowlist on a Capella cluster" maybe? I think we've moved away from using whitelist?
chvck
reviewed
Aug 7, 2024
src/cli/allow_ip.rs
Outdated
| } | ||
|
|
||
| fn format_ip_address(ip_address: String) -> String { | ||
| if !ip_address.ends_with("/32") { |
There was a problem hiding this comment.
ip address can't be any other format can it? Just checking that we aren't blocking some usage.
There was a problem hiding this comment.
The addresses required a subnet mask, and if not given the UI defaults to try and use '/32', so I've changed this to behave the same.
ef38752
to
e036f8c
Compare
fbe4913
to
cf8f5e7
Compare
cf8f5e7
to
efd1e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - needs rebase once register cluster on creation is merged