Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO change tutorials to permanent redirect #764

Conversation

RayOffiah
Copy link
Contributor

Not sure how to go about testing this. I assume there must be some way to set up a fake harness to test a rewrites.conf change.

However, I am fairly confident that this won't break anything! 🤞🏾

@RayOffiah RayOffiah self-assigned this May 20, 2024
@RayOffiah RayOffiah requested a review from osfameron May 20, 2024 08:32
Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really confused, I thought I saw this PR last week and approved it...
Anyway, I think we're OK to test it manually, in live 🤠

❯ curl --head https://docs.couchbase.com/tutorials/
HTTP/2 302 
content-type: text/html
content-length: 138
location: http:https://developer.couchbase.com/tutorials/
...

Let's get it merged in, rerun that Curl, and document that it's now a 301.
If it isn't (or there's any unexpected consequences), then we'll just roll back!

@RayOffiah
Copy link
Contributor Author

RayOffiah commented May 20, 2024

I'm really confused, I thought I saw this PR last week and approved it... Anyway, I think we're OK to test it manually, in live 🤠

❯ curl --head https://docs.couchbase.com/tutorials/
HTTP/2 302 
content-type: text/html
content-length: 138
location: http:https://developer.couchbase.com/tutorials/
...

Let's get it merged in, rerun that Curl, and document that it's now a 301. If it isn't (or there's any unexpected consequences), then we'll just roll back!

Yeah, I had a PR for the staging site, but that doesn't seem to have built properly since mid-April, I think. This is the same change for the live site.
But sounds like a plan! 👍🏾

@RayOffiah RayOffiah merged commit cad7bf4 into couchbase:master May 20, 2024
@RayOffiah
Copy link
Contributor Author

@osfameron
Yep, the CURL thing works a treat (should have thought of that!)

@RayOffiah RayOffiah deleted the SEO-change-tutorials-to-permanent-redirect branch May 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants