Support for multiple macros on the same page #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, the current design assumes there is only one hardcoded swagger-ui div per page. When the macro is used multiple times, the content goes always to the 1st div. This proposed change is to parametrize the div name and script name using a simple global counter.
osfameron
reviewed
Jan 3, 2023
There was a problem hiding this comment.
Hi @LukeCz, this is interesting thank you for the contribution.
I don't know of cases where we want to have multiple SwaggerUI macros, does this PR respond to a particular requirement or bug on a specific page in the Couchbase docs?
If it's a general enhancement for all users of Antora, it might be worth suggesting to https://gitlab.com/antora/antora/ (and we do periodically update our extensions from this upstream as required).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the current design assumes there is only one hardcoded swagger-ui div per page. When the macro is used multiple times, the content goes always to the 1st div. This proposed change is to parametrize the div name and script name using a simple global counter.