Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an apparently longstanding issue with core boolean methods #1631

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix an apparently longstanding issue with core boolean methods #1631

merged 1 commit into from
Jun 20, 2024

Conversation

borrrden
Copy link
Member

If they return false with an error code of 0, the platform interprets that (incorrectly) as true

@borrrden
Fix an apparently longstanding issue with core boolean methods
bf0787e 
If they return false with an error code of 0, the platform interprets that (incorrectly) as true
@borrrden borrrden requested review from bmeike and pasin June 20, 2024 00:47
bmeike
bmeike approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had so much trouble with this stuff. The party line is: "It works like this except when it doesn't. 'When it doesn't' is documented in comments" Its a PITA

@borrrden borrrden merged commit e02d395 into release/3.2 Jun 20, 2024
1 check failed
@borrrden borrrden deleted the fix/core_always_true branch June 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeike bmeike bmeike approved these changes

@pasin pasin Awaiting requested review from pasin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borrrden @bmeike