CBL-4452: Migrate to nullable reference types in tests #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borrrden
added a commit
that referenced
this pull request
Mar 21, 2024
borrrden
added a commit
that referenced
this pull request
Mar 22, 2024
bmeike
approved these changes
Mar 26, 2024
pasin
approved these changes
May 29, 2024
Massive amount of lines changed but 95% of it is just removing `#nullable disabled` and then addressing the various `?` and `!` needed. I tried to be mostly diligent about adding a null check to the test before adding `!` but toward the end and the 1000th time doing it for basically the same functionality I gave up. CBL-5547 This uncovered three nullability regressions though (you can see them in the non test files). I filed one as a ticket, but will cover all three with the same ticket. I also added in an assembly property to not auto append the git SHA to the version, so that it remains pure as x.y.z-bdddd
borrrden
force-pushed
the
fix/cbl-4452_and_cbl-5547
branch
from
070d349
to
1169ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive amount of lines changed but 95% of it is just removing
#nullable disabledand then addressing the various?and!needed. I tried to be mostly diligent about adding a null check to the test before adding!but toward the end and the 1000th time doing it for basically the same functionality I gave up.CBL-5547
This uncovered three nullability regressions though (you can see them in the non test files). I filed one as a ticket, but will cover all three with the same ticket.
I also added in an assembly property to not auto append the git SHA to the version, so that it remains pure as x.y.z-bdddd