Purge all compiler warnings #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority are simply the compiler being confused about the signature saying "not null" and then an immediate check if the value is null or not. It errs on the safe side and issues warnings about a possible null value on some platforms but not others. The compiler will let you know if you are potentially passing a null to a method that cannot accept it, and so the null checks are all less important now. Also fill in missing doc comments and update all bad refs between doc pages (including changes to gen_defaults.py)
bmeike
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority are simply the compiler being confused about the signature saying "not null" and then an immediate check if the value is null or not. It errs on the safe side and issues warnings about a possible null value on some platforms but not others. The compiler will let you know if you are potentially passing a null to a method that cannot accept it, and so the null checks are all less important now.
Also fill in missing doc comments and update all bad refs between doc pages (including changes to gen_defaults.py)