CBL-3032 Replication Network Interface option test #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borrrden
requested changes
May 28, 2022
| InValidAddress | ||
| } | ||
|
|
||
| #if !__ANDROID__ && !__IOS__ //Cannot run this test in emulators |
There was a problem hiding this comment.
I guess I can test this with actual devices. But they are not unit testable. I will report the result after device testing.
There was a problem hiding this comment.
Created an iOS ticket CBL-3620
There was a problem hiding this comment.
Test update to get NI tests work with Android device: 92f15e2
There was a problem hiding this comment.
There should be nothing stopping testing on actual devices, but what is the issue with emulators?
Sandychuang8
force-pushed
the
feature/CBL-3032
branch
2 times, most recently
from
9b17983
to
69df951
Compare
Sandychuang8
force-pushed
the
feature/CBL-3032
branch
2 times, most recently
from
f2161e6
to
8d3368b
Compare
added 6 commits
December 2, 2022 15:02
… unreachable server
Sandychuang8
force-pushed
the
feature/CBL-3032
branch
from
8d3368b
to
637e15f
Compare
added 3 commits
December 3, 2022 12:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note in Android device testing: If uses NI "lo" or it's IPv6 address "::1" will not connect to the remote end, I have to mask them to IPv4 address in order to get the connection to work.
Note in OSX testing: ethernet "en0" is found but there is no cable connected to it will result in Invalid Network Interface when trying to connect to the remote end.
NOTE: https://github.com/couchbase/couchbase-lite-net/blob/master/src/Couchbase.Lite.Shared/Sync/Reachability.cs#L88-L109 has to be used in Valid NI check as well!!!