Fix test databases not deleted #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeike
reviewed
Jul 14, 2022
| @@ -71,7 +71,7 @@ static Object toCBLObject(@Nullable Object value) { | |||
|
|
|||
| throw new IllegalArgumentException( | |||
| Log.formatStandardMessage( | |||
There was a problem hiding this comment.
I've accepted the rest of this... but this looks wrong to me. What is your reasoning?
There was a problem hiding this comment.
I described this a bit more here.
|
Btw... FWIW, most of your previously requested changes made it in to release 3.0.2, which should go out very shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 databases that aren't cleaned up after being created in tests. After running tests repeatedly, these 4 databases will continue to duplicate. This properly handles deleting these databases, or in one instance, the base test DB fails to be deleted because a handle isn't closed.
Fixes couchbase/couchbase-lite-java-ce-root#19.
Also fix a
Mapvariable, writing to the wrong map and an incorrect error message.