Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement replicator’s server cert and accept only self-signed cert #8

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

pasin
Copy link
Contributor

@pasin pasin commented Jul 29, 2020

  • Implemented CBLTrustManager to support listening to server certs received, pinned cert, and accept only self-signed cert feature.

  • Updated AbstractCBLWebSocket to use CBLTrustManager.

  • Wired up from Replicator -> SocketFactor -> CBLWebSocket -> CBLTrustManager to listen to get server certificates available in the Replicator.

  • Reference: CBL-1167 and CBL-1168

* Implemented CBLTrustManager to support listening to server certs received, pinned cert, and accept only self-signed cert feature.

* Updated AbstractCBLWebSocket to use CBLTrustManager.

* Wired up from Replicator -> SocketFactor -> CBLWebSocket -> CBLTrustManager to listen to get server certificates available in the Replicator.

* Reference: CBL-1167 and CBL-1168
@pasin pasin requested a review from bmeike July 29, 2020 22:16
Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions offline

@pasin pasin merged commit 6fc4a9e into master Jul 30, 2020
@pasin pasin deleted the feature/CBL-1167-1168 branch July 30, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants