Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBL-3023: correctly handle SocketTimeoutException #70

Merged
merged 2 commits into from
Apr 22, 2022
Merged

CBL-3023: correctly handle SocketTimeoutException #70

merged 2 commits into from
Apr 22, 2022

Conversation

bmeike
Copy link
Contributor

@bmeike bmeike commented Apr 20, 2022

Correct handling of SocketTimeoutException. Similar treatment of PortUnreachableException and NoRouteToHostException

@borrrden : will the use of domain C4Constants.ErrorDomain.NETWORK and code C4Constants.NetworkError.HOST_UNREACHABLE work in Hydrogen LiteCore?

@bmeike bmeike added the bug Something isn't working label Apr 20, 2022
@bmeike bmeike added this to the 2.8.9 milestone Apr 20, 2022
@bmeike bmeike self-assigned this Apr 20, 2022
@borrrden
Copy link
Member

No unfortunately, those constants are not present in Hydrogen.

borrrden
borrrden requested changes Apr 20, 2022
View reviewed changes
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as is (thanks for the heads up). Either Core or Java needs to change. As it stands I am not sure what will happen if this is merged. Probably turn into an "unknown error" of sorts.

@borrrden
Copy link
Member

Note: We do have kC4NetErrTimeout (3) in the network domain in hydrogen, which is retryable.

@bmeike bmeike requested a review from borrrden April 21, 2022 23:53
@bmeike bmeike merged commit cbba1dc into android/release/hydrogen Apr 22, 2022
@bmeike bmeike deleted the fix/CBL-3023 branch April 22, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borrrden borrrden borrrden approved these changes

@LaurenNguyen14 LaurenNguyen14 LaurenNguyen14 approved these changes

Assignees

@bmeike bmeike

Labels
bug Something isn't working
Projects
None yet
Milestone
2.8.9
3 participants
@bmeike @borrrden @LaurenNguyen14