Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBL-2835: enable core logging domains #60

Merged
merged 1 commit into from
Feb 23, 2022
Merged

CBL-2835: enable core logging domains #60

merged 1 commit into from
Feb 23, 2022

Conversation

bmeike
Copy link
Contributor

@bmeike bmeike commented Feb 18, 2022

I'm not entirely clear on the goal for this ticket. Would you please check to be sure I've done the right thing?

borrrden
borrrden reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasin What is the final word about the SQL domain? That would be the only change here that I could think of if SQL is too spammy.

@pasin
Copy link
Contributor

pasin commented Feb 18, 2022 •
edited
Loading

I haven't looked it yet.

@jayahariv Can you share two logs at the info level and at the verbose level to see how noisy it is?

@jayahariv
Copy link
Contributor 

2022-02-18 16:52:33.858853-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, extra FROM kv_info WHERE key=?
2022-02-18 16:52:33.865022-0800 xctest[58686:2377830] CouchbaseLite Database Info: Compiling SQL "SELECT sequence, flags, null, version, length(body), length(extra) FROM kv_del_default WHERE key=?"
2022-02-18 16:52:33.865388-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, length(body), length(extra) FROM kv_del_default WHERE key=?
2022-02-18 16:52:33.865539-0800 xctest[58686:2377830] CouchbaseLite Database Info: Compiling SQL "INSERT OR IGNORE INTO kv_default (version, body, extra, flags, sequence, key) VALUES (?, ?, ?, ?, ?, ?)"
2022-02-18 16:52:33.865793-0800 xctest[58686:2377830] CouchbaseLite Database Info: Compiling SQL "SELECT lastSeq FROM kvmeta WHERE name=?"
2022-02-18 16:52:33.866027-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... SELECT lastSeq FROM kvmeta WHERE name=?
2022-02-18 16:52:33.866160-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... INSERT OR IGNORE INTO kv_default (version, body, extra, flags, sequence, key) VALUES (?, ?, ?, ?, ?, ?)
2022-02-18 16:52:33.866322-0800 xctest[58686:2377830] CouchbaseLite Database Verbose: Saved doc 'doc-001' #1-4d3e510cffc0cfe295a8015b46d819e2531c072f; body=266, extra=34
2022-02-18 16:52:33.866495-0800 xctest[58686:2377830] CouchbaseLite Database Verbose: {DB#1} Saved 'doc-001' rev #1-4d3e510cffc0cfe295a8015b46d819e2531c072f as seq 1
20
...
...
2022-02-18 16:52:34.079682-0800 xctest[58686:2377830] CouchbaseLite Query Info: End of query enumeration (0x60b00009fb10)
2022-02-18 16:52:34.079870-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, length(extra) FROM kv_default WHERE key=?
2022-02-18 16:52:34.080184-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, length(extra) FROM kv_default WHERE key=?
2022-02-18 16:52:34.080435-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, length(extra) FROM kv_default WHERE key=?
2022-02-18 16:52:34.080839-0800 xctest[58686:2377830] CouchbaseLite Query Info: {QueryEnum#5} Deleted
2022-02-18 16:52:34.082276-0800 xctest[58686:2377830] CouchbaseLite Query Info: {QueryEnum#4} Deleted
2022-02-18 16:52:34.082582-0800 xctest[58686:2377830] CouchbaseLite Database Info: Closing CBLDatabase[testdb] at path /var/folders/gk/xfc67g4s27v6jrn_5tjhg0y80000gp/T/CouchbaseLite_EE/testdb.cblite2/
2022-02-18 16:52:34.082865-0800 xctest[58686:2377830] CouchbaseLite Database Verbose: PRAGMA optimize ... 400
2022-02-18 16:52:34.083033-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... PRAGMA page_count
2022-02-18 16:52:34.083166-0800 xctest[58686:2377830] CouchbaseLite Database Info: ... PRAGMA freelist_count
2022-02-18 16:52:34.083287-0800 xctest[58686:2377830] CouchbaseLite Database Verbose: {DB#1} Housekeeping: 0 of 20 pages free (0%)
2022-02-18 16:52:34.084661-0800 xctest[58686:2377830] CouchbaseLite Database Verbose: {DB#1} Closed SQLite database
2022-02-18 16:52:34.084795-0800 xctest[58686:2377830] CouchbaseLite Database Info: {DB#1} Closing database
2022-02-18 16:52:34.084937-0800 xctest[58686:2377830] CouchbaseLite Database Info: {CollectionImpl#6}==> litecore::CollectionImpl testdb/_default @0x60b00003a820
2022-02-18 16:52:34.085037-0800 xctest[58686:2377830] CouchbaseLite Database Info: {CollectionImpl#6} Closed
...
...
2022-02-18 16:55:56.521578-0800 xctest[59019:2383092] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, length(extra) FROM kv_default WHERE key=?
2022-02-18 16:55:56.521938-0800 xctest[59019:2383092] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, length(extra) FROM kv_default WHERE key=?
2022-02-18 16:55:56.522219-0800 xctest[59019:2383092] CouchbaseLite Database Info: ... SELECT sequence, flags, null, version, body, length(extra) FROM kv_default WHERE key=?
2022-02-18 16:55:56.522539-0800 xctest[59019:2383092] CouchbaseLite Query Info: {QueryEnum#8} Deleted
2022-02-18 16:55:56.522733-0800 xctest[59019:2383092] CouchbaseLite Query Info: {QueryEnum#7} Deleted
2022-02-18 16:55:56.523005-0800 xctest[59019:2383092] CouchbaseLite Query Info: {QueryEnum#5} Deleted
2022-02-18 16:55:56.524245-0800 xctest[59019:2383092] CouchbaseLite Query Info: {QueryEnum#4} Deleted
2022-02-18 16:55:56.524804-0800 xctest[59019:2383092] CouchbaseLite Database Info: Closing CBLDatabase[testdb] at path /var/folders/gk/xfc67g4s27v6jrn_5tjhg0y80000gp/T/CouchbaseLite_EE/testdb.cblite2/
2022-02-18 16:55:56.525209-0800 xctest[59019:2383092] CouchbaseLite Database Verbose: PRAGMA optimize ... 400
2022-02-18 16:55:56.525434-0800 xctest[59019:2383092] CouchbaseLite Database Info: ... PRAGMA page_count
2022-02-18 16:55:56.525680-0800 xctest[59019:2383092] CouchbaseLite Database Info: ... PRAGMA freelist_count
2022-02-18 16:55:56.525883-0800 xctest[59019:2383092] CouchbaseLite Database Verbose: {DB#1} Housekeeping: 0 of 11 pages free (0%)
2022-02-18 16:55:56.527247-0800 xctest[59019:2383092] CouchbaseLite Database Verbose: {DB#1} Closed SQLite database
2022-02-18 16:55:56.527378-0800 xctest[59019:2383092] CouchbaseLite Database Info: {DB#1} Closing database
2022-02-18 16:55:56.527526-0800 xctest[59019:2383092] CouchbaseLite Database Info: {CollectionImpl#9}==> litecore::CollectionImpl testdb/_default @0x60b000035020
2022-02-18 16:55:56.527650-0800 xctest[59019:2383092] CouchbaseLite Database Info: {CollectionImpl#9} Closed

@bmeike bmeike merged commit 2c0ab07 into master Feb 23, 2022
@bmeike bmeike deleted the fix/CBL-2835 branch February 23, 2022 21:38
@bmeike
Copy link
Contributor Author

bmeike commented Feb 23, 2022 •
edited
Loading

Merging. If it turns out that SQL is too verbose, please file a ticket to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borrrden borrrden borrrden left review comments

@pasin pasin Awaiting requested review from pasin

@jayahariv jayahariv Awaiting requested review from jayahariv

@LaurenNguyen14 LaurenNguyen14 Awaiting requested review from LaurenNguyen14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@bmeike @pasin @jayahariv @borrrden