Add C4Listener and JNI support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayahariv
reviewed
Jun 9, 2020
common/main/cpp/native_c4listener.cc
Outdated
| // | ||
| // native_c4listener.cc | ||
| // | ||
| // Copyright (c) 2017 Couchbase, Inc All rights reserved. |
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2017 Couchbase, Inc All rights reserved. | |
| // Copyright (c) 2020 Couchbase, Inc All rights reserved. |
jayahariv
approved these changes
Jun 9, 2020
pasin
approved these changes
Jun 9, 2020
common/CMakeLists.txt
Outdated
| FleeceStatic | ||
| "-Wl,--no-whole-archive" |
There was a problem hiding this comment.
Is this intention (-Wl,--whole-archive and -Wl,--no-whole-archive)?
There was a problem hiding this comment.
Yes. It doesn't work wo/ that. Seems like a linker bug to me. Jim says it is SOP.
| config.allowCreateDBs = allowCreateDBs; | ||
| config.allowDeleteDBs = allowDeleteDBs; | ||
|
|
||
| auto listener = c4listener_start(&config, &error); |
| Java_com_couchbase_lite_internal_core_C4Listener_getUriFromPath | ||
| (JNIEnv *env, jclass clazz, jlong c4Listener, jstring path) { | ||
| jstringSlice pathSlice(env, path); | ||
| auto uri = c4db_URINameFromPath(pathSlice); |
|
|
||
| static { | ||
| final Map<KeyMode, Integer> m = new HashMap<>(); | ||
| m.put(KeyMode.CERT, 1); |
There was a problem hiding this comment.
For consistency, use hex like OPTION_TO_C4 or the other way around?
There was a problem hiding this comment.
Wait. Options are bit flags. They need to be hex. Certs modes are not. They are mutually exclusive.
These declarations are identical to the ones in c4Listener.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch in C4Listener and its JNI support.