Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build_liteCore files #51

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Fix build_liteCore files #51

merged 2 commits into from
Nov 19, 2021

Conversation

LaurenNguyen14
Copy link
Contributor

  • Get rid of unreference code in build_litecore.sh
  • Fix build_litecore.bat

bmeike
bmeike approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the one noted change that I mistakenly advised.

Ok to commit, after that.

tools/build_litecore.sh Outdated Show resolved Hide resolved
@LaurenNguyen14 LaurenNguyen14 merged commit 3ac1644 into java/release/3.0 Nov 19, 2021
@LaurenNguyen14 LaurenNguyen14 deleted the fix/build_liteCore branch November 19, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeike bmeike bmeike approved these changes

@borrrden borrrden borrrden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@LaurenNguyen14 @bmeike @borrrden