Release leaking certs #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borrrden
approved these changes
Nov 5, 2021
common/main/cpp/native_c4listener.cc
Outdated
| @@ -574,6 +574,8 @@ JNICALL Java_com_couchbase_lite_internal_core_impl_NativeC4Listener_startTls( | |||
| jboolean enableDeltaSync, | |||
| jboolean requirePasswordAuth) { | |||
| C4TLSConfig tlsConfig = {}; | |||
| tlsConfig.rootClientCerts = nullptr; | |||
| tlsConfig.certificate = nullptr; | |||
There was a problem hiding this comment.
These two lines are redundant with the {} initializer (which basically memsets the whole thing to 0).
There was a problem hiding this comment.
Ah... I wondered about that. I wasn't sure that was guaranteed to be initialized. Will remove.
LaurenNguyen14
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pasin found a couple of memory leaks. This is the fix.