P2P API #4
Merged
P2P API #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
requested changes
May 28, 2020
| } | ||
|
|
||
| //@NonNull | ||
| public TLSIdentity getIdentity( |
There was a problem hiding this comment.
Missing throws CouchbaseLiteException.
| } | ||
|
|
||
| //@NonNull | ||
| public TLSIdentity createIdentity( |
There was a problem hiding this comment.
Missing throws CouchbaseLiteException.
| } | ||
|
|
||
| //@NonNull | ||
| public TLSIdentity importIdentity( |
There was a problem hiding this comment.
Missing throws CouchbaseLiteException.
| return null; | ||
| } | ||
|
|
||
| public void deleteIdentity(@NonNull String alias) { } |
There was a problem hiding this comment.
Missing throws CouchbaseLiteException.
| @@ -937,7 +937,7 @@ private boolean filterDocument( | |||
| long dict, | |||
| boolean isPush) { | |||
| final ReplicationFilter filter = (isPush) ? config.getPushFilter() : config.getPullFilter(); | |||
| return filter.filtered(new Document(getDatabase(), docId, revId, new FLDict(dict)), flags); | |||
| return (filter != null) && filter.filtered(new Document(getDatabase(), docId, revId, new FLDict(dict)), flags); | |||
| private Date expiration; | ||
|
|
||
| @Nullable | ||
| protected List<Certificate> getCerts() { return certs; } |
| @Nullable | ||
| protected Date getExpiration() { return expiration; } | ||
|
|
||
| protected void setExpiration(@Nullable Date expiration) { this.expiration = expiration; } |
| @Nullable | ||
| protected List<Certificate> getCerts() { return certs; } | ||
|
|
||
| protected void setCerts(@Nullable List<Certificate> certs) { this.certs = certs; } |
| public class TLSIdentity extends AbstractTLSIdentity { | ||
|
|
||
| @Nullable | ||
| public TLSIdentity getIdentity(KeyStore keyStore, String alias, byte[] keyPassword) { |
There was a problem hiding this comment.
Missing throws CouchbaseLiteException.
| return null; | ||
| } | ||
|
|
||
| public TLSIdentity createIdentity( |
There was a problem hiding this comment.
Missing throws CouchbaseLiteException.
pasin
requested changes
May 28, 2020
| public class TLSIdentity extends AbstractTLSIdentity { | ||
|
|
||
| @Nullable | ||
| public TLSIdentity getIdentity(@NonNull String alias, @Nullable byte[] keyPassword) { |
| } | ||
|
|
||
| //@NonNull | ||
| public TLSIdentity createIdentity( |
| return null; | ||
| } | ||
|
|
||
| public void deleteIdentity(@NonNull String alias) { } |
| } | ||
|
|
||
| //@NonNull | ||
| public TLSIdentity importIdentity( |
|
All errors repaired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is PR https://github.com/couchbaselabs/couchbase-lite-java-ee-root/pull/6
but working...
Implementation of the P2P API.