CBL-5794: FLSliceResult leaks memory #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
approved these changes
Jun 7, 2024
| // NOTE: We expect the FLSliceResult returned by this method to be handed, immediately, | ||
| // to someone else (LiteCore) who will release it. Java does release the memory. | ||
| @NonNull | ||
| public FLSliceResult finish3() throws LiteCoreException { return impl.nFinish3(getPeer()); } |
There was a problem hiding this comment.
Trying to think about a better name than 1, 2, 3 but it's hard to come up with a good one. Maybe finishAndGetManagedFLSliceResult (how long is this?).
There was a problem hiding this comment.
I absolutely agree. I am going to rename them. I just didn't want to make this commit even bigger than it already is. I think "EncodedToByteArray", "EncodeToSliceResult", and EncodeToUnmanagedSliceResult".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLSliceResult is not freeing the block of memory it frames. This is an enormous memory leak.
This is a minimal backport of #296: the SliceResult is freed by the finalizer; not explicitly.
Also removed an unused file logger function