Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getBinaryFileLevel from the public API #294

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove getBinaryFileLevel from the public API #294

merged 1 commit into from
May 23, 2024

Conversation

bmeike
Copy link
Contributor

@bmeike bmeike commented May 23, 2024

Also clean up some ResultSet code

@bmeike bmeike requested review from pasin and borrrden May 23, 2024 19:27
@bmeike bmeike self-assigned this May 23, 2024
pasin
pasin approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@pasin pasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only see the change related to getBinaryFileLevel in jni_android.ld so I guessed there are some other changes in another repo.

@bmeike
Copy link
Contributor Author

bmeike commented May 23, 2024

@pasin : exactly. most of the linker files are platform/ee specific

@bmeike bmeike merged commit 86ff95a into master May 23, 2024
@bmeike bmeike deleted the pr/fixBuild branch May 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasin pasin pasin approved these changes

@borrrden borrrden Awaiting requested review from borrrden

Assignees

@bmeike bmeike

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bmeike @pasin