Several fixes #289
Merged
Several fixes #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borrrden
reviewed
May 9, 2024
| namespace jni { | ||
| static std::unordered_set<std::string> gDomainNames; | ||
|
|
||
| // Assert: jdomain is not null |
There was a problem hiding this comment.
null would be fine, LiteCore auto maps null to empty string aka default
There was a problem hiding this comment.
I think this will fail on null:
std::string domain = JstringToUTF8(env, jdomain);
borrrden
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bigger than it should be. Sorry about that. The native crash is the biggest fix. The ClientTask fix is more contained but, perhaps, more important. The rest is just preening.
CBL-5729: Prevent native crash on unknown log domain
CBL-5714: API Doc: Can't start a replicator inside a batch block
CBL-5658: Tune the ClientTask executor
CBL-5651: Tests for LiteCore callbacks