Android/vf/3.1.6 vf001

[bmeike]

This is the VF for CBSE-16470
I would very much appreciate additional eyes on it. It does three things:

1. Native JSONEncoder_finishJSON now throws a LiteCore exception instead of returning null. All of the methods that use it wrap the (checked) exception in (unchecked) IllegalStateException. No API change; Container toJSON methods cannot return null.
2. The context object that becomes the parent of the tree of children belonging to a ResultSet, now holds a reference to the ResultSet. There will be references to the ResultSet until the last child goes away
3. The close() method on ResultSet no longer does anything. Instead the Fleece object is freed by a finalizer. The finalizer code is insane because Android does not appear to handle the use of locks correctly.

[borrrden]

I think the goal is accomplished, looks like one place now is somewhat of a no-op (marked with comment)

[borrrden]

Hmmm, is this ever going to be true? Doesn't the no-op close prevent this?

[bmeike]

yeah. good point.
I may leave it along because it doesn't hurt anything and messing with it is more changes...

[bmeike]

Thanks for the review, Jim!