Update to LiteCore 3.2.0-148 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just note that I still see failing date time tests with this version of Core |
borrrden
previously approved these changes
Mar 7, 2024
bmeike
force-pushed
the
pr/core-148
branch
2 times, most recently
from
d6d35b4
to
2f929da
Compare
Use the latest autogenerated Defaults
|
Yes. I see those Date/Time failures too. I'm not going to address them until Core gets stable. |
pasin
requested changes
Mar 7, 2024
| @@ -71,7 +71,7 @@ class ReplicatorConfigurationTest : BaseReplicatorTest() { | |||
| val opts = immutableConfig.connectionOptions | |||
| assertEquals(Defaults.Replicator.HEARTBEAT, opts[C4Replicator.REPLICATOR_HEARTBEAT_INTERVAL]) | |||
| assertEquals(Defaults.Replicator.MAX_ATTEMPTS_SINGLE_SHOT - 1, opts[C4Replicator.REPLICATOR_OPTION_MAX_RETRIES]) | |||
| assertEquals(Defaults.Replicator.MAX_ATTEMPT_WAIT_TIME, opts[C4Replicator.REPLICATOR_OPTION_MAX_RETRY_INTERVAL]) | |||
| assertEquals(Defaults.Replicator.MAX_ATTEMPTS_WAIT_TIME, opts[C4Replicator.REPLICATOR_OPTION_MAX_RETRY_INTERVAL]) | |||
There was a problem hiding this comment.
To be correct, I think we will need to deprecate the old one.
There was a problem hiding this comment.
Seem like this will get taken care as a separate PR.
There was a problem hiding this comment.
Yeah.... Defaults.java is in (two) other repositories
pasin
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to LiteCore 148: