Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial implemention of Vector Search #250

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Partial implemention of Vector Search #250

merged 2 commits into from
Feb 7, 2024

Conversation

bmeike
Copy link
Contributor

@bmeike bmeike commented Feb 7, 2024

Includes some tests and a previous commit that fixes some old tests

This is work in progress. Many of the methods are incomplete.

@bmeike bmeike requested review from pasin and borrrden February 7, 2024 17:15
@bmeike bmeike self-assigned this Feb 7, 2024
Copy link
Member

@borrrden borrrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up with more comments than I thought

Copy link
Contributor

@pasin pasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we release the vector search extension for android as an AAR on a maven server or a downloadable zip file containing .so files?

If we are doing AAR on a maven server, I understand that users will use the vector search like below.

implementation 'com.couchbase.lite:couchbase-lite-android-ee:3.2.0'
implementation 'com.couchbase.lite:couchbase-lite-vector-search-extension:1.0.0'

This would mean that the location of the vector search binary will be where the Android OS put the Native libraries for the application. So I'm not sure if there will be cases that user will customize the location beside using the default location.

@bmeike
Copy link
Contributor Author

bmeike commented Feb 7, 2024

@pasin That is totally your call. If we don't expose a path for the VS lib, things get a lot easier.

@bmeike
Copy link
Contributor Author

bmeike commented Feb 7, 2024

Changed to remove client specified extension path

@bmeike bmeike requested review from borrrden and pasin February 7, 2024 22:51
@bmeike bmeike merged commit b94e70d into master Feb 7, 2024
@bmeike bmeike deleted the pr/CBL-5325 branch February 7, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants