v2.8.6: Android API 30 compatibility #25
Conversation
| android:label="@string/app_name" | ||
| android:usesCleartextTraffic="true" | ||
| /> | ||
| </manifest> |
There was a problem hiding this comment.
There is also the same file in android/androidTest folder. What is the purpose of this one and the other one in androidTest folder?
There was a problem hiding this comment.
Yeah... that's mysterious. Android builds the debug flavor of the library, for testing. It then builds an entirely different application that contains the tests. Both of those applications need to allow clear text traffic, in order for the tests (which use cleartext most fo the time) to pass.
| @@ -63,7 +62,7 @@ private CancellableTask(@NonNull Handler handler, @NonNull Runnable task) { | |||
| // Constructor | |||
| //--------------------------------------------- | |||
| public AndroidExecutionService() { | |||
| super((ThreadPoolExecutor) AsyncTask.THREAD_POOL_EXECUTOR); | |||
| super(new CBLExecutor()); | |||
There was a problem hiding this comment.
Oh, it's good to know that the AsyncTask is not deprecated!
There was a problem hiding this comment.
It is deprecated! It is not backed by a SynchronousQueue (a queue with max size 1!). That makes it pretty unusable (as was the intention) for people like us.
The Android cert verification process calls, by reflection, a completely non-standard method.
I've added that method and refactored the standard method, so that both use the same code to either defer to the default, or to use the CBL checks.
Also, AsyncTasks have been deprecated in v30. The Executor that powered them is no longer useful for CBL. I've replaced it with a small, internal execution service.
Any other changes are just things to get the test code to run