Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database.getDefaultCollection() should be non-null #245

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

jeffdgr8
Copy link
Collaborator

Translate default scope/collection tests from Swift. Also, add missing @Test annotation to some collection tests.

@bmeike
Copy link
Contributor

bmeike commented Apr 19, 2024

Jeff: our API tzar wants to keep this nullable. Being unable to delete the default collection is kind of an odd artifact of the current implementation. We may, very well, allow deleting it at some point in the future.

@bmeike bmeike self-assigned this Apr 19, 2024
@jeffdgr8
Copy link
Collaborator Author

The Swift API is non-null. Should this be changed to nullable then?

@bmeike
Copy link
Contributor

bmeike commented Apr 26, 2024

Well... they should be the same! I will check.

@bmeike bmeike changed the base branch from master to jeffl/nullable April 26, 2024 18:02
@bmeike bmeike merged commit d59f535 into couchbase:jeffl/nullable Apr 26, 2024
@bmeike
Copy link
Contributor

bmeike commented Apr 26, 2024

Turns out that all of the other platforms went with non-null. It is easier to change Java than to change all the rest. This will go into 3.2.0 and subsequent releases. 3.1.7 is already out the door, so I won't be able to do it there.

bmeike added a commit that referenced this pull request Apr 26, 2024
bmeike added a commit that referenced this pull request Apr 26, 2024
@bmeike
Copy link
Contributor

bmeike commented Apr 29, 2024

Turns out that all the other platforms went with non-null, and it is easier to change Java than to change all the others.
I will make that method @nonnull in 3.2 and subsequent releases.

@bmeike
Copy link
Contributor

bmeike commented Apr 29, 2024

Jeff: this change is now in the master and release/3.2 branches. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants