CBL-5213: Proxy auth #236
CBL-5213: Proxy auth #236
Conversation
|
|
||
| builder.authenticator((route, resp) -> authenticate(resp, credentials)); | ||
| if ((proxyCredentials != null) || (endpointCredentials != null)) { | ||
| builder.authenticator((route, resp) -> authenticate(resp, endptCred, proxyCred)); |
There was a problem hiding this comment.
Not using builder.proxyAuthenticator for authenticating with the proxy?
There was a problem hiding this comment.
Or is this for the preemptive authenticator which handles both endpoint and proxy auth?
There was a problem hiding this comment.
Following this code sample, from the OkHttp 3.14 (the version we use) docs:
https://square.github.io/okhttp/3.x/okhttp/okhttp3/Authenticator.html
As I understand it, I will get this callback, preemptively, so that OkHttp has the credentials before it tries to connect.
I could be mistaken.
There was a problem hiding this comment.
I see. I think it could be a good idea if we do a manual test at least once to confirm that all are correct including the OkHttp-Preemptive challenge name.
|
|
||
| builder.authenticator((route, resp) -> authenticate(resp, credentials)); | ||
| if ((proxyCredentials != null) || (endpointCredentials != null)) { | ||
| builder.authenticator((route, resp) -> authenticate(resp, endptCred, proxyCred)); |
There was a problem hiding this comment.
I see. I think it could be a good idea if we do a manual test at least once to confirm that all are correct including the OkHttp-Preemptive challenge name.
|
I totally agree. We need to see how this works in the real world, on a couple versions of Android. It is going to be quite hard to set up the test, though. Perhaps with Charles.... |
|
I used https://mitmproxy.org before and there was a customer using http:https://www.squid-cache.org. |
Tests for CBL-5201, CBL-5207, CBL-5213