CBL-5024: Prevent native crash referencing Result after ResultSet.close() #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
approved these changes
Nov 2, 2023
| * | ||
| * A Result may be referenced <b>only</b> while the ResultSet that contains it is open. | ||
| * An Attempt to reference a Result after calling ResultSet.close on the ResultSet that | ||
| * contains it will throw and IllegalStateException |
pasin
reviewed
Nov 2, 2023
| public static final String CHANGES = "Changes"; | ||
| public static final String DATABASE = "DB"; | ||
| public static final String ENUM = "Enum"; |
There was a problem hiding this comment.
Does .NET also enable these 3 new log domains or just define them for domain mapping? We may need to do the same for iOS.
There was a problem hiding this comment.
I am not sure.... but I think not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix up some logging domain stuff, per .NET