Some refactoring to simplify a few things #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Listener interface Convert C4CollectionDocObserver and C4CollectionObserver to TaggedWeakPeerBinding
pasin
approved these changes
Oct 12, 2023
| * @param ign1 ref for the C4Document observer: ignored | ||
| * @param ign2 ref for the C4Collection: ignored | ||
| * @param ign3 the doc id: ignored | ||
| * @param context the token bound to the observer instance. |
There was a problem hiding this comment.
There are 5 params. docID is mixed up with ign3 in the comment above.
|
|
||
| // Requiring implementer to specify the types of both T and the ChangeListener for T | ||
| // is pretty ugly and annoying. I could not figure out another way to do it, though... | ||
| public interface Listenable<T, L extends ChangeListener<T>> { |
There was a problem hiding this comment.
I might have missed. I don't see it is implemented anywhere in this PR.
There was a problem hiding this comment.
wow.... good catch!!
I have no idea what happened there....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the logger: it used to be in a package called "support", which, I think, was meant to hold a bunch of utility stuff. Logging was the only thing there, though, so I've moved it to a package called "logging" for clarity
Move the Listener interface: Similarly, the listener interface obviously belongs in the listener package. Put it there
Convert C4CollectionDocObserver and C4CollectionObserver to TaggedWeakPeerBinding: TaggedWeakPeerBinding is more explicit that peer binding and should be used wherever possible. Only Sockets still use the latter.
All tests pass on multiple devices