Check heartbeat bounds #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
approved these changes
Feb 4, 2021
| @@ -21,6 +21,9 @@ | |||
| import java.util.HashMap; | |||
| import java.util.List; | |||
| import java.util.Map; | |||
| import java.util.concurrent.TimeUnit; | |||
|
|
|||
| import okhttp3.internal.Util; | |||
There was a problem hiding this comment.
It's internal!. I'm fine with this but just want to point it out. We probably needs to change a bunch of things when upgrading okhttp anyway incase the internal classes are gone.
There was a problem hiding this comment.
Yes... It's a very, very fair point.
It was my opinion that it was less fragile to use the exact check that they use, than to try to duplicate a possibly moving target. Absolutely open to opinions to the contrary
|
BTW, please note that, although not visible in the PR, this update includes the deprecation (simply marked "deprecated") of LogLevel.getValue() |
borrrden
approved these changes
Feb 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp explodes trying to set a ping interval > MAX_INT. The explosion doesn't happen until the replicator actually tries to connect.
This code uses the same check that OkHttp uses, guaranteeing that if you can set the heartbeat in the config, it will work when the replicator connects.