Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBL-3108 and others: Finish adding JNI proxy classes #218

Merged
merged 1 commit into from
Sep 28, 2023
Merged

CBL-3108 and others: Finish adding JNI proxy classes #218

merged 1 commit into from
Sep 28, 2023

Conversation

bmeike
Copy link
Contributor

@bmeike bmeike commented Sep 27, 2023 •
edited
Loading

Lots of files touched, very little code actually changed.

  • Deleted many empty .h files
  • Deleted redundant NativeC4Query .h file
  • Added JNI proxies for Blob, Fleece and C4Document. These will make it possible to unit-test the C4 classes.
  • Added an idiom to check for errant ART nulling of references (mostly iimpl) during finalization. Does not affect Java, When the condition occurs, Android will leak native memory, but will not crash
  • FLArray and FLDict Iterator factories are now part of FLDict and FLArray, as makes sense.
  • Removed completely incorrect "DO NOT EDIT" comment

JIRA issues: CBL-3108, CBL-3106, CBL-3107, CBL-3103, CBL-4951, CBL-4952, CBL-4951, CBL-4950

@bmeike bmeike requested a review from pasin September 27, 2023 22:10
@bmeike bmeike merged commit ec858cb into master Sep 28, 2023
@bmeike bmeike deleted the pr/CBL-3108 branch September 28, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasin pasin pasin approved these changes

Assignees

@bmeike bmeike

@pasin pasin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bmeike @pasin