Unit test for CBL-4841 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that this issue has enough information inside of it. It's the same argument as not writing a link only answer in Stack Overflow (if the link is ever gone for whatever reason, you lose context about what happened). |
|
You seem to be saying that this test, even with its copious comments and reference to the bug for which it is a test, should not be part of the codebase. I am honestly speechless. Here it is in Kotlin. See if that's clearer. |
pasin
approved these changes
Aug 29, 2023
|
I said no such thing, I am just speaking regarding the comments on the commit / PR itself. In my opinion it should contain information on what CBL-4841 is and what the test tests to fix it. The test itself looks fine. |
|
Ahh! I see. I completely misunderstood what you were talking about. Fixing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a unit test for CBL-4841.
A logic bug caused any document replicated in a pull replication to be scheduled for conflict resolution.