CBL-1048: char[] encoding in Fleece encoder #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
requested changes
Aug 26, 2023
common/main/cpp/native_glue.cc
Outdated
| if (length <= 0) { | ||
| _slice = kFLSliceNull; | ||
| } else { | ||
| auto *chars = env->GetByteArrayElements(jchars, nullptr); |
There was a problem hiding this comment.
char* needs be released after use. jbyteArraySlice does handle that.
There was a problem hiding this comment.
Woo.... Thanks Pasin!
There was a problem hiding this comment.
Fixed. Actually, you fixed it...
pasin
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some other "in passing" fixes here. Mostly though, I'd appreciate having you look at
jstringSlice::jstringSlice(JNIEnv *env, jbyteArray jchars)That's the heart of the matter.
testBasicAuthOptionsverifies that the authenticator password option does, in fact, make it to the network code as a string.