Update dev tests to use current APIs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
approved these changes
Apr 17, 2023
|
|
||
| if (e != null) err.compareAndSet(null, e) | ||
|
|
||
| if (stoppedStates.contains(level)) latch.countDown() |
There was a problem hiding this comment.
Noted : if there is a test that add docs in different rate (e.g. keep adding docs in parallels), the IDLE status cannot be trust to determine that the replicator is finished replicating as it could be BUSY -> IDLE -> BUSY - IDLE. I recently found this issue in one of the LiteCore's flaky tests.
borrrden
approved these changes
Apr 18, 2023
|
@borrrden : yep. As discussed, I have yet to come up with any reasonable way of doing pre-commit validation on a submodule. This stuff will be validated as part of the root module commit. |
bmeike
added a commit
that referenced
this pull request
Apr 18, 2023
* CBL-3887: ReplicatorCollectionTest rewritten to avoid using deprecated methods
* DatabaseTest no longer depends on deprecated API
* New, non-expired certs for CBLTrustManagerTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two big test suites: DatabaseTest and ReplicatorCollectionTest
Also, port CBL-4423 (stop live queries on DB close) to beryllium