Fix for CBL-1406 Java #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borrrden
approved these changes
Dec 16, 2020
pasin
approved these changes
Dec 16, 2020
bmeike
added a commit
that referenced
this pull request
Jan 15, 2021
* Fix for CBL-1406 Java (#16) * CBL 1441: don't abort on unrecognized replicator state * Fix CBL-1537: Replicator.start should not be deprecated * Fix CBL-1440: FLSliceResult leaks memory * Fix CBL-1051: synchronization in finalizer * Fix CBL-1491, CBL-1495, CBL-1527: Replicator hangs * CBL-370: make ReplicatorType visible from Kotlin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the Java side of the 2.8.0 bug.
I confirm that my tests were passing because the "real" root directory was still .../.couchbase. The code that fixes the (Android) problem, then, looks for the directory .../.couchbase/.couchbase. Since it will never find such a directory, I do not believe that the problem has gotten any worse.
Changes are as follows:
CouchbaseLiteInternal.java: DEFAULT_ROOT_DIR_NAME is empty: This is the main issue. Changing this effectively fixes the problem. Everything else is a consequence of changing this.
CouchbaseLiteInternal.java: verifyDir: "".exists() always returns
false. Have to get the canonical file before checking for existence.DatabaseTest.java: testReOpenExistingDb: verify that the default database path no longer ends with ".couchbase"
BaseTest.java: tearDownBaseTestClass: One of the main reasons for adding the .couchbase namespace was so that it was possible to clean up after running automated tests. Since they now run in the current directory, there's now way to do that safely, anymore.