Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query tests according to specs #115

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fix query tests according to specs #115

merged 1 commit into from
Aug 29, 2022

Conversation

LaurenNguyen14
Copy link
Contributor

Test for CBL-3135 (core ticket: CBL-3626)

@LaurenNguyen14
Copy link
Contributor Author

After the fix in testStringQueryJoinWithCollections(), the test no longer throws exception but the query result is wrong. The test is tagged with the corresponding ticket.

Copy link
Contributor

@bmeike bmeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with the exception of the test of the JSON on line 3400. I don't think there is any guarantee about the order in which things will get put into the string...

@LaurenNguyen14 LaurenNguyen14 merged commit 319b3b1 into master Aug 29, 2022
@LaurenNguyen14 LaurenNguyen14 deleted the fix/CBL-3558 branch August 29, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants